[PATCH] staging: android: ion: Use DEFINE_DEBUGFS_ATTRIBUTE

From: Tommy Nguyen
Date: Sun Jun 25 2017 - 08:22:44 EST


Running coccicheck indicates that DEFINE_DEBUGFS_ATTRIBUTE
and debugfs_create_file_unsafe should be used instead.

Signed-off-by: Tommy Nguyen <remyabel@xxxxxxxxx>
---
drivers/staging/android/ion/ion.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c
index 03d3a4f..8f96b38 100644
--- a/drivers/staging/android/ion/ion.c
+++ b/drivers/staging/android/ion/ion.c
@@ -544,8 +544,8 @@ static int debug_shrink_get(void *data, u64 *val)
return 0;
}

-DEFINE_SIMPLE_ATTRIBUTE(debug_shrink_fops, debug_shrink_get,
- debug_shrink_set, "%llu\n");
+DEFINE_DEBUGFS_ATTRIBUTE(debug_shrink_fops, debug_shrink_get,
+ debug_shrink_set, "%llu\n");

void ion_device_add_heap(struct ion_heap *heap)
{
@@ -579,7 +579,7 @@ void ion_device_add_heap(struct ion_heap *heap)
char debug_name[64];

snprintf(debug_name, 64, "%s_shrink", heap->name);
- debug_file = debugfs_create_file(
+ debug_file = debugfs_create_file_unsafe(
debug_name, 0644, dev->debug_root, heap,
&debug_shrink_fops);
if (!debug_file) {
--
2.9.4