Re: [RFC PATCH linux-next] usb: gadget: udc: start_udc() can be static

From: Raviteja Garimella
Date: Fri Jun 23 2017 - 07:30:56 EST


Looks good to me.

Thanks,
Ravi

On Fri, Jun 23, 2017 at 4:50 PM, kbuild test robot
<fengguang.wu@xxxxxxxxx> wrote:
>
> Signed-off-by: Fengguang Wu <fengguang.wu@xxxxxxxxx>
> ---
> snps_udc_plat.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/usb/gadget/udc/snps_udc_plat.c b/drivers/usb/gadget/udc/snps_udc_plat.c
> index 2e11f19..f7b4d0f 100644
> --- a/drivers/usb/gadget/udc/snps_udc_plat.c
> +++ b/drivers/usb/gadget/udc/snps_udc_plat.c
> @@ -28,7 +28,7 @@
> /* description */
> #define UDC_MOD_DESCRIPTION "Synopsys UDC platform driver"
>
> -void start_udc(struct udc *udc)
> +static void start_udc(struct udc *udc)
> {
> if (udc->driver) {
> dev_info(udc->dev, "Connecting...\n");
> @@ -38,7 +38,7 @@ void start_udc(struct udc *udc)
> }
> }
>
> -void stop_udc(struct udc *udc)
> +static void stop_udc(struct udc *udc)
> {
> int tmp;
> u32 reg;
> @@ -76,7 +76,7 @@ void stop_udc(struct udc *udc)
> dev_info(udc->dev, "Device disconnected\n");
> }
>
> -void udc_drd_work(struct work_struct *work)
> +static void udc_drd_work(struct work_struct *work)
> {
> struct udc *udc;
>