Re: [PATCH v1] ARM: dts: sun7i: provide ramoops region on BananaPi

[Maxime Ripard]

Hi Oleksij,

On Wed, Jun 21, 2017 at 07:10:17PM +0200, Oleksij Rempel wrote:
> This should help provide useful debug information on remote
> targets without UART.
> 
> Signed-off-by: Oleksij Rempel <linux@xxxxxxxxxxxxxxxx>
> ---
>  arch/arm/boot/dts/sun7i-a20-bananapi.dts | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/sun7i-a20-bananapi.dts b/arch/arm/boot/dts/sun7i-a20-bananapi.dts
> index ed2f35a..38923bf 100644
> --- a/arch/arm/boot/dts/sun7i-a20-bananapi.dts
> +++ b/arch/arm/boot/dts/sun7i-a20-bananapi.dts
> @@ -63,6 +63,22 @@
>  		stdout-path = "serial0:115200n8";
>  	};
>  
> +	reserved-memory {
> +		#address-cells = <1>;
> +		#size-cells = <1>;
> +		ranges;
> +
> +		ramoops@7fb6a000 {
> +			compatible = "ramoops";
> +			reg = <0x7fb6a000 0x100000>;
> +			ecc-size	= <16>;
> +			record-size	= <0x00020000>;
> +			console-size	= <0x00020000>;
> +			ftrace-size	= <0x00020000>;
> +			pmsg-size	= <0x00020000>;
> +		};
> +	};
> +

I'm a bit skeptical about this one.

First, there's nothing specific to the bananapi, but every one will
want to have different sizes here, or different parameters.

Since using the kernel parameters is also an option, I'd rather
document how to do that with the parameters.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Attachment: signature.asc
Description: PGP signature