Re: [PATCH 11/32] ext4: clean up ext4_xattr_inode_get()

From: Theodore Ts'o
Date: Wed Jun 21 2017 - 21:58:48 EST


On Wed, Jun 21, 2017 at 02:21:21PM -0700, Tahsin Erdogan wrote:
> The input and output values of *size parameter are equal on successful
> return from ext4_xattr_inode_get(). On error return, the callers ignore
> the output value so there is no need to update it.
>
> Also check for NULL return from ext4_bread(). If the actual xattr inode
> size happens to be smaller than the expected size, ext4_bread() may
> return NULL which would indicate data corruption.
>
> Signed-off-by: Tahsin Erdogan <tahsin@xxxxxxxxxx>

Thanks, applied.

- Ted