Re: [PATCH v4 20/28] ARM: owl: Implement CPU enable-method for S500

From: Arnd Bergmann
Date: Wed Jun 21 2017 - 06:25:43 EST


On Wed, Jun 21, 2017 at 10:16 AM, Arnd Bergmann <arnd@xxxxxxxx> wrote:
> On Tue, Jun 6, 2017 at 2:54 AM, Andreas FÃrber <afaerber@xxxxxxx> wrote:
>> Allow to bring up CPU1.
>>
>> Based on LeMaker linux-actions tree.
>>
>> Signed-off-by: Andreas FÃrber <afaerber@xxxxxxx>
>> ---
>> v3 -> v4: Unchanged
>>
>> v3: new
>>
>> arch/arm/mach-actions/Makefile | 3 +
>> arch/arm/mach-actions/headsmp.S | 68 ++++++++++++++++
>> arch/arm/mach-actions/platsmp.c | 166 ++++++++++++++++++++++++++++++++++++++++
>
> I now see build errors in linux-next:
>
> /git/arm-soc/arch/arm/mach-actions/platsmp.c: In function 'write_pen_release':
> /git/arm-soc/arch/arm/mach-actions/platsmp.c:39:2: error:
> 'pen_release' undeclared (first use in this function); did you mean

I have a fix and tested it now. Please fold this into your patch:

Arnd

Subject: [PATCH] ARM: owl: fix non-SMP build

arch/arm/mach-actions/platsmp.c: In function 'write_pen_release':
arch/arm/mach-actions/platsmp.c:39:2: error: 'pen_release' undeclared
(first use in this function); did you mean 'seq_release'?

Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>

diff --git a/arch/arm/mach-actions/Makefile b/arch/arm/mach-actions/Makefile
index 217e95d04b43..94f8dbafba21 100644
--- a/arch/arm/mach-actions/Makefile
+++ b/arch/arm/mach-actions/Makefile
@@ -1,4 +1,4 @@
-obj-$(CONFIG_ARCH_ACTIONS) += owl.o
-obj-${CONFIG_ARCH_ACTIONS} += platsmp.o headsmp.o
+obj-y += owl.o
+obj-$(CONFIG_SMP) += platsmp.o headsmp.o

AFLAGS_headsmp.o := -Wa,-march=armv7-a