RE: [PATCH net-next 6/9] net: hns3: Add MDIO support to HNS3 Ethernet driver for hip08 SoC

From: Salil Mehta
Date: Sat Jun 17 2017 - 07:11:17 EST


Hi Andrew

> -----Original Message-----
> From: Andrew Lunn [mailto:andrew@xxxxxxx]
> Sent: Wednesday, June 14, 2017 2:10 AM
> To: Salil Mehta
> Cc: Florian Fainelli; davem@xxxxxxxxxxxxx; Zhuangyuzeng (Yisen);
> huangdaode; lipeng (Y); mehta.salil.lnk@xxxxxxxxx;
> netdev@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Linuxarm
> Subject: Re: [PATCH net-next 6/9] net: hns3: Add MDIO support to HNS3
> Ethernet driver for hip08 SoC
>
> > Since I would be touching the core, lots of drivers will get impacted
> and will
> > have to wait till everyone gives clean signal. This will impact our
> internal
> > deadlines. But as I said I am eager to cooperate & contribute :)
>
> Just as an FYI.
>
> Your internal deadlines are irrelevant. We will reject your patches
> until we are happy with it. We probably won't accept a hack around a
> core feature limitation. We will want you to fix the core limitation
> and then do it right in the driver.
>
> Andrew

We are dropping the support of C45 in our driver till we fix the issue
just commented upon. I will try to fix this issue and would soon float
a separate patch for that. Later, we shall re-introduce the support of
C45 in our HNS3 driver once the PHY core fix has been reviewed and accepted.

Thanks
Salil