Re: [RFT 2/2] pinctrl: samsung: Fix invalid register offset used for Exynos5433 external interrupts

[Sylwester Nawrocki]

On 06/14/2017 03:18 PM, Krzysztof Kozlowski wrote:
> When setting the pin function for external interrupts, the driver used
> wrong IO memory address base.  The pin function register is always under
> pctl_base, not the eint_base.
>
> By updating wrong register, the external interrupts for chosen GPIO
> would not work at all and some other GPIO might be configured to wrong
> value.
>
> Platforms other than Exynos5433 should not be affected as eint_base
> equals pctl_base in such case.
>
> Fixes: 8b1bd11c1f8f ("pinctrl: samsung: Add the support the multiple IORESOURCE_MEM for one pin-bank")
> Cc:<stable@xxxxxxxxxxxxxxx>
> Reported-by: Tomasz Figa<tomasz.figa@xxxxxxxxx>
> Signed-off-by: Krzysztof Kozlowski<krzk@xxxxxxxxxx>

The patch looks good to me, I'll try to test it later today.

Reviewed-by: Sylwester Nawrocki <s.nawrocki@xxxxxxxxxxx>

--
Thanks,
Sylwester