Re: [PATCH] block: swim3: make of_device_ids const.

From: Johannes Thumshirn
Date: Fri Jun 16 2017 - 07:48:36 EST


On Fri, Jun 16, 2017 at 03:24:39PM +0530, Arvind Yadav wrote:
> of_device_ids are not supposed to change at runtime. All functions
> working with of_device_ids provided by <linux/of.h> work with const
> of_device_ids. So mark the non-const structs as const.
>
> File size before:
> text data bss dec hex filename
> 8908 1096 624 10628 2984 drivers/block/swim3.o
>
> File size after constify swim3_match:
> text data bss dec hex filename
> 9708 296 624 10628 2984 drivers/block/swim3.o
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@xxxxxxxxx>
> ---


Reviewed-by: Johannes Thumshirn <jthumshirn@xxxxxxx>
--
Johannes Thumshirn Storage
jthumshirn@xxxxxxx +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850