RE: [PATCH] staging: fsl-mc/dpio: Propagate error code

[Bogdan Purcareata]

> -----Original Message-----
> From: Ioana Radulescu [mailto:ruxandra.radulescu@xxxxxxx]
> Sent: Thursday, June 15, 2017 11:55 AM
> To: gregkh@xxxxxxxxxxxxxxxxxxx
> Cc: devel@xxxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> agraf@xxxxxxx; arnd@xxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; Bogdan
> Purcareata <bogdan.purcareata@xxxxxxx>; stuyoder@xxxxxxxxx; Laurentiu Tudor
> <laurentiu.tudor@xxxxxxx>; Ruxandra Ioana Radulescu
> <ruxandra.radulescu@xxxxxxx>; Roy Pledge <roy.pledge@xxxxxxx>; Haiying Wang
> <haiying.wang@xxxxxxx>
> Subject: [PATCH] staging: fsl-mc/dpio: Propagate error code
> 
> dpaa2_io_service_register() returns zero even if
> qbman_swp_CDAN_set() encountered an error. Fix this
> by propagating the error code so the caller is informed
> data availability notifications are not properly set
> for a channel.
> 
> Signed-off-by: Ioana Radulescu <ruxandra.radulescu@xxxxxxx>

Acked-by: Bogdan Purcareata <bogdan.purcareata@xxxxxxx>

> ---
>  drivers/staging/fsl-mc/bus/dpio/dpio-service.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/fsl-mc/bus/dpio/dpio-service.c
> b/drivers/staging/fsl-mc/bus/dpio/dpio-service.c
> index e5d66749614c..762f045f53f7 100644
> --- a/drivers/staging/fsl-mc/bus/dpio/dpio-service.c
> +++ b/drivers/staging/fsl-mc/bus/dpio/dpio-service.c
> @@ -260,9 +260,9 @@ int dpaa2_io_service_register(struct dpaa2_io *d,
> 
>  	/* Enable the generation of CDAN notifications */
>  	if (ctx->is_cdan)
> -		qbman_swp_CDAN_set_context_enable(d->swp,
> -						  (u16)ctx->id,
> -						  ctx->qman64);
> +		return qbman_swp_CDAN_set_context_enable(d->swp,
> +							 (u16)ctx->id,
> +							 ctx->qman64);
>  	return 0;
>  }
>  EXPORT_SYMBOL(dpaa2_io_service_register);
> --
> 2.11.0