Re: [PATCH 1/2] perf evsel: Fix probing of precise_ip level for default cycles event

From: Arnaldo Carvalho de Melo
Date: Wed Jun 14 2017 - 10:45:05 EST


Em Wed, Jun 14, 2017 at 03:55:22PM +0200, Ingo Molnar escreveu:
>
> * Arnaldo Carvalho de Melo <acme@xxxxxxxxxx> wrote:
>
> > Em Wed, Jun 14, 2017 at 12:51:55PM +0200, Ingo Molnar escreveu:
> > >
> > > * Arnaldo Carvalho de Melo <acme@xxxxxxxxxx> wrote:
> > >
> > > > Can you try with the patch below, which is hackish but the minimal fix at this
> > > > point. Later I'll come up with a way of returning a fully configured cycles
> > > > evsel, which will make the tools code simpler, moving more stuff to the
> > > > libraries.
> > >
> > > Yeah, this patch on top of your tree seems to work better now.
> >
> > So how do we proceed, do you want to keep these two as separate or can I
> > squash them together, fix that problem with the unwind library and
> > provide a new perf/urgent for you to use?
> >
> > Off to breakfast now tho :-)
>
> Your call: I had to unpull, so feel free to rebase your urgent branch.

Ok, I'll rebase it, prepare another pull req after we nail down the
unwind one.

- Arnaldo