Re: [B.A.T.M.A.N.] Odd use of %14pM in net/batman-adv/distributed-arp-table.c

From: Joe Perches
Date: Wed Jun 14 2017 - 05:33:26 EST


On Wed, 2017-06-14 at 10:23 +0200, Sven Eckelmann wrote:
> On Dienstag, 13. Juni 2017 14:51:41 CEST Joe Perches wrote:
> > An output mac address is 17 bytes
>
> [...]
> > but in net/batman-adv/distributed-arp-table.c
>
> [...]
> > %14pM is odd as this should not emit the last byte of the
> > mac address. So given the example above, it would output
> > 00:11:22:33:44
>
> [...]
>
> I completely agree too the "wrong length" part. It is currently not omitting
> the last byte:

Right, I only looked at vsprintf.c and mistook precision for
field_width.

Do you want to provide a patch to convert it to simple %pM's?

OK.