Re: [PATCH v4 14/16] perf tool: add show_feature_header to perf_tool

[Jiri Olsa]

On Mon, Jun 12, 2017 at 09:29:30PM -0700, David Carrillo-Cisneros wrote:
> Add show_feat_hdr to control level of printed information
> of feature headers.
> 
> Signed-off-by: David Carrillo-Cisneros <davidcc@xxxxxxxxxx>
> ---
>  tools/perf/builtin-report.c | 11 ++++++++---
>  tools/perf/builtin-script.c |  3 +++
>  tools/perf/util/tool.h      |  7 +++++++
>  3 files changed, 18 insertions(+), 3 deletions(-)
> 
> diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
> index 22478ff2b706..7620d708c78b 100644
> --- a/tools/perf/builtin-report.c
> +++ b/tools/perf/builtin-report.c
> @@ -985,9 +985,14 @@ int cmd_report(int argc, const char **argv)
>  		perf_hpp_list.need_collapse = true;
>  	}
>  
> -	/* Force tty output for header output and per-thread stat. */
> -	if (report.header || report.header_only || report.show_threads)
> -		use_browser = 0;
> +	if (report.header || report.header_only) {
> +		report.tool.show_feat_hdr = SHOW_FEAT_HEADER;
> +		/* Force tty output for header output and per-thread stat. */
> +		if (report.show_threads)
> +			use_browser = 0;
> +	}

this breaks show_threads option.. simple 'perf report -T' will not set use_browser

jirka