Re: [PATCH] Add printk for bonding module packets_per_slave parameter

From: David Miller
Date: Tue Jun 13 2017 - 11:34:18 EST


From: Michael Dilmore <michael.j.dilmore@xxxxxxxxx>
Date: Tue, 13 Jun 2017 14:42:46 +0100

> The packets per slave parameter used by round robin mode does not have a printk debug
> message in its set function in bond_options.c. Adding such a function would aid debugging
> of round-robin mode and allow the user to more easily verify that the parameter has been
> set correctly. I should add that I'm motivated by my own experience here - it's not
> obvious from output of tools such as wireshark and ifstat that the parameter is working
> correctly, and with the differences in bonding configuration across different distributions,
> it would have been comforting to see this output.
>
> Signed-off-by: Michael Dilmore <michael.j.dilmore@xxxxxxxxx>
>
> cc: Veaceslav Falico <vfalico@xxxxxxxxx>,Andy Gospodarek <andy@xxxxxxxxxxxxx>,netdev@xxxxxxxxxxxxxxx,linux-kernel@xxxxxxxxxxxxxxx

You can verify things by simplying reading the value back.

If every parameter emitted a kernel log message, it would be
unreadable.

I'm not applying this, sorry.