Re: [PATCH 2/2] tty/serial: atmel: make the driver DT only

[Andy Shevchenko]

On Tue, Jun 13, 2017 at 4:40 PM, Alexandre Belloni
<alexandre.belloni@xxxxxxxxxxxxxxxxxx> wrote:
> Now that AVR32 is gone, platform_data are not used to initialize the driver
> anymore, remove that path from the driver. Also remove the now unused
> struct atmel_uart_data.

Nitpicks, not insisting on them at all, just a side comment.

> +       struct serial_rs485 *rs485conf = &port->rs485;
> +       u32 rs485_delay[2];

+ empty line?

> +       /* rs485 properties */

> +       if (of_property_read_u32_array(np, "rs485-rts-delay",
> +                                      rs485_delay, 2) == 0) {

Now it can be one line I suppose (taking into account ...() == 0 ->
!...() change)

-- 
With Best Regards,
Andy Shevchenko