Re: [PATCH] of: Provide dummy of_device_compatible_match() for compile-testing

From: Geert Uytterhoeven
Date: Tue Jun 13 2017 - 06:32:30 EST


On Tue, Apr 25, 2017 at 7:38 PM, Geert Uytterhoeven
<geert+renesas@xxxxxxxxx> wrote:
> Most of_device_*() functions have dummy versions for CONFIG_OF=n,
> but of_device_compatible_match() hasn't. Fix that to improve the
> ability to do compile-testing.
>
> Fixes: b9c13fe32faaa71c ("dt: Add of_device_compatible_match()")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>

Any reason not to apply this patch?

Thanks!

> ---
> include/linux/of.h | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/include/linux/of.h b/include/linux/of.h
> index 21e6323de0f3b786..bfd1a23221735161 100644
> --- a/include/linux/of.h
> +++ b/include/linux/of.h
> @@ -620,6 +620,12 @@ static inline int of_device_is_compatible(const struct device_node *device,
> return 0;
> }
>
> +static inline int of_device_compatible_match(struct device_node *device,
> + const char *const *compat)
> +{
> + return 0;
> +}
> +
> static inline bool of_device_is_available(const struct device_node *device)
> {
> return false;
> --
> 2.7.4