Re: [PATCH] nvme: use uuid_t in nvme_ns

From: Andy Shevchenko
Date: Sat Jun 10 2017 - 11:40:27 EST


On Sat, Jun 10, 2017 at 4:03 PM, Johannes Thumshirn <jthumshirn@xxxxxxx> wrote:

> struct nvme_ns still uses u u8 uuid[16], change it to using uuid_t.

...and we can convert to use UUID API.

> - memcpy(ns->uuid, data + pos + sizeof(*cur), len);
> + memcpy(&ns->uuid, data + pos + sizeof(*cur), len);

uuid_copy()

> - if (!memchr_inv(ns->uuid, 0, sizeof(ns->uuid))) {
> + if (!memchr_inv(&ns->uuid, 0, sizeof(ns->uuid))) {

uuid_is_null()

> - if (!memchr_inv(ns->uuid, 0, sizeof(ns->uuid)) ||
> + if (!memchr_inv(&ns->uuid, 0, sizeof(ns->uuid)) ||

Ditto.

--
With Best Regards,
Andy Shevchenko