Re: [PATCH 15/16] tty: serdev: use dev_groups and not dev_attrs for bus_type

From: Stephen Rothwell
Date: Fri Jun 09 2017 - 20:01:29 EST


Hi Greg,

On Sat, 10 Jun 2017 09:56:49 +1000 Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> wrote:
>
> > +static struct attribute *serdev_device_attrs[] = {
> ^^^^^^^^^^^^^^^^^^^
> Should have been "serdev_device_groups"

Sorry, my mistake.

> > + &dev_attr_modalias.attr,
> > + NULL,
> > };
> > +ATTRIBUTE_GROUPS(serdev_device);

I really hate macros that create symbols by concatenating parts. :-(

--
Cheers,
Stephen Rothwell