Re: [PATCH] gpio: mvebu: change compatible string for PWM support

From: Ralph Sennhauser
Date: Fri Jun 09 2017 - 16:13:01 EST


On Fri, 9 Jun 2017 09:42:26 +0200
Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:

> On Thu, Jun 1, 2017 at 10:08 PM, Ralph Sennhauser
> <ralph.sennhauser@xxxxxxxxx> wrote:
>
> > As it turns out more than just Armada 370 and XP support using GPIO
> > lines as PWM lines. For example the Armada 38x family has the same
> > hardware support. As such "marvell,armada-370-xp-gpio" for the
> > compatible string is a misnomer.
> >
> > Change the compatible string to "marvell,armada-370-gpio" before the
> > driver makes it out of the -rc stage. This also follows the
> > practice of using only the first device family supported as part of
> > the name.
> >
> > Also update the documentation and comments in the code accordingly.
> >
> > Fixes: 757642f9a584 ("gpio: mvebu: Add limited PWM support")
> > Signed-off-by: Ralph Sennhauser <ralph.sennhauser@xxxxxxxxx>
>
> Patch applied for next with the tags.

Hi Linus,

As Richard already correctly pointed out this needs to go into 4.12 as
we can't really change the compatible string after 4.12 final was
released. So this commit was pushed to the wrong branch. Sorry for
not having been more explicit in my wording.

Thanks
Ralph