RE: [PATCH] Drivers: unisys: visorhba - style fix

From: Kershner, David A
Date: Fri Jun 09 2017 - 10:32:31 EST


> -----Original Message-----
> From: Derek Robson [mailto:robsonde@xxxxxxxxx]
> Sent: Friday, June 9, 2017 1:16 AM
> To: Kershner, David A <David.Kershner@xxxxxxxxxx>;
> gregkh@xxxxxxxxxxxxxxxxxxx; Binder, David Anthony
> <David.Binder@xxxxxxxxxx>; Sell, Timothy C <Timothy.Sell@xxxxxxxxxx>;
> Wadgaonkar, Sameer Laxmikant <Sameer.Wadgaonkar@xxxxxxxxxx>;
> Thompson, Bryan E. <bryan.thompson@xxxxxxxxxx>; robsonde@xxxxxxxxx
> Cc: *S-Par-Maintainer <SParMaintainer@xxxxxxxxxx>;
> devel@xxxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> Subject: [PATCH] Drivers: unisys: visorhba - style fix
>
> Fixed style of permissions to octal.
> Found using checkpatch
>
> Signed-off-by: Derek Robson <robsonde@xxxxxxxxx>

Acked-by: David Kershner <david.kershner@xxxxxxxxxx>

> ---
> drivers/staging/unisys/visorhba/visorhba_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/unisys/visorhba/visorhba_main.c
> b/drivers/staging/unisys/visorhba/visorhba_main.c
> index 2fd31c9762c6..a6e7a6bbc428 100644
> --- a/drivers/staging/unisys/visorhba/visorhba_main.c
> +++ b/drivers/staging/unisys/visorhba/visorhba_main.c
> @@ -1090,7 +1090,7 @@ static int visorhba_probe(struct visor_device *dev)
> goto err_scsi_remove_host;
> }
> devdata->debugfs_info =
> - debugfs_create_file("info", S_IRUSR | S_IRGRP,
> + debugfs_create_file("info", 0440,
> devdata->debugfs_dir, devdata,
> &info_debugfs_fops);
> if (!devdata->debugfs_info) {
> --
> 2.13.0