Re: [PATCH v2] dell-rbtn: constify rfkill_ops structures

From: Andy Shevchenko
Date: Fri Jun 09 2017 - 06:25:28 EST


On Fri, Jun 9, 2017 at 8:57 AM, Bhumika Goyal <bhumirks@xxxxxxxxx> wrote:
> Add const to rfkill_ops structures that are only passed as an argument
> to the functions rfkill_alloc or samsung_new_rfkill. These arguments are
> of type const, so such structures can be annotated with const.
>

All three pushed to testing, thanks

> Signed-off-by: Bhumika Goyal <bhumirks@xxxxxxxxx>
> ---
> Changes since v1:
> * Split the changes to one patch per vendor.
>
> drivers/platform/x86/dell-rbtn.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/dell-rbtn.c b/drivers/platform/x86/dell-rbtn.c
> index dcd9f40..6b5bbaf 100644
> --- a/drivers/platform/x86/dell-rbtn.c
> +++ b/drivers/platform/x86/dell-rbtn.c
> @@ -110,7 +110,7 @@ static int rbtn_rfkill_set_block(void *data, bool blocked)
> return -EINVAL;
> }
>
> -static struct rfkill_ops rbtn_ops = {
> +static const struct rfkill_ops rbtn_ops = {
> .query = rbtn_rfkill_query,
> .set_block = rbtn_rfkill_set_block,
> };
> --
> 2.7.4
>



--
With Best Regards,
Andy Shevchenko