Re: [PATCH v5] fpga manager: Add Altera CvP driver

From: Anatolij Gustschin
Date: Thu Jun 08 2017 - 11:00:32 EST


On Thu, 8 Jun 2017 17:44:19 +0300
Andy Shevchenko andy.shevchenko@xxxxxxxxx wrote:

>On Thu, Jun 8, 2017 at 5:15 PM, Anatolij Gustschin <agust@xxxxxxx> wrote:
>> On Thu, 8 Jun 2017 02:38:55 +0300
>> Andy Shevchenko andy.shevchenko@xxxxxxxxx wrote:
>>>On Thu, Jun 8, 2017 at 2:09 AM, Anatolij Gustschin <agust@xxxxxxx> wrote:
>>>> On Fri, 2 Jun 2017 20:43:21 +0300
>>>> Andy Shevchenko andy.shevchenko@xxxxxxxxx wrote:
>
>>>Besides below comments, please, do
>>>
>>>s/VSEC_/VSE_/g
>>>
>>>for entire file.
>>>
>>>We are following PCI and Thunderbolt pattern for use of Vendor
>>>Specific Extended Capability.
>>
>> I can do it, but I'm just not getting why. The registers are named as VSEC
>> registers in the documentation, why should the code name them differently?
>
>Does your documentation decode VSEC abbreviation?
>What C stands for? Capability?

the CvP user guide talks about Vendor Specific Extended Capability (VSEC).

--
Anatolij