Re: [PATCH 03/20] asm-generic: Drop getrlimit and setrlimit syscalls from default list

From: Yury Norov
Date: Wed Jun 07 2017 - 14:48:32 EST


On Mon, Jun 05, 2017 at 03:44:06PM +0100, James Hogan wrote:
> Hi Yury,
>
> On Sun, Jun 04, 2017 at 02:59:52PM +0300, Yury Norov wrote:
> > The newer prlimit64 syscall provides all the functionality provided by
> > the getrlimit and setrlimit syscalls and adds the pid of target process,
> > so future architectures won't need to include getrlimit and setrlimit.
> >
> > Therefore drop getrlimit and setrlimit syscalls from the generic syscall
> > list unless __ARCH_WANT_SET_GET_RLIMIT is defined by the architecture's
> > unistd.h prior to including asm-generic/unistd.h, and adjust all architectures
> > using the generic syscall list to define it so that no in-tree architectures
> > are affected.
> >
> > Cc: Arnd Bergmann <arnd@xxxxxxxx>
> > Cc: James Hogan <james.hogan@xxxxxxxxxx>
> > Cc: linux-arch@xxxxxxxxxxxxxxx
> > Cc: linux-snps-arc@xxxxxxxxxxxxxxxxxxx
> > Cc: Catalin Marinas <catalin.marinas@xxxxxxx>
> > Cc: Will Deacon <will.deacon@xxxxxxx>
> > Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> > Cc: Mark Salter <msalter@xxxxxxxxxx>
> > Cc: Aurelien Jacquiot <a-jacquiot@xxxxxx>
> > Cc: linux-c6x-dev@xxxxxxxxxxxxx
> > Cc: Richard Kuo <rkuo@xxxxxxxxxxxxxx>
> > Cc: linux-hexagon@xxxxxxxxxxxxxxx
> > Cc: linux-metag@xxxxxxxxxxxxxxx
> > Cc: Jonas Bonn <jonas@xxxxxxxxxxxx>
> > Cc: linux@xxxxxxxxxxxxxxxxxx
> > Cc: Chen Liqin <liqin.linux@xxxxxxxxx>
> > Cc: Lennox Wu <lennox.wu@xxxxxxxxx>
> > Cc: Chris Metcalf <cmetcalf@xxxxxxxxxxxx>
> > Cc: Guan Xuetao <gxt@xxxxxxxxxxxxxxx>
> > Cc: Ley Foon Tan <lftan@xxxxxxxxxx>
> > Cc: nios2-dev@xxxxxxxxxxxxxxxxxxxxxx
> > Cc: Yoshinori Sato <ysato@xxxxxxxxxxxxxxxxxxxx>
> > Cc: uclinux-h8-devel@xxxxxxxxxxxxxxxxxxxx
> > Signed-off-by: Yury Norov <ynorov@xxxxxxxxxxxxxxxxxx>
> > Acked-by: Arnd Bergmann <arnd@xxxxxxxx>
> > Acked-by: Mark Salter <msalter@xxxxxxxxxx> [c6x]
> > Acked-by: James Hogan <james.hogan@xxxxxxxxxx> [metag]
> > Acked-by: Ley Foon Tan <lftan@xxxxxxxxxx> [nios2]
> > Acked-by: Stafford Horne <shorne@xxxxxxxxx> [openrisc]
> > Acked-by: Will Deacon <will.deacon@xxxxxxx> [arm64]
> > Acked-by: Vineet Gupta <vgupta@xxxxxxxxxxxx> #arch/arc bits
> > ---
> > arch/arc/include/uapi/asm/unistd.h | 1 +
> > arch/arm64/include/uapi/asm/unistd.h | 1 +
> > arch/c6x/include/uapi/asm/unistd.h | 1 +
> > arch/h8300/include/uapi/asm/unistd.h | 1 +
> > arch/hexagon/include/uapi/asm/unistd.h | 1 +
> > arch/metag/include/uapi/asm/unistd.h | 1 +
> > arch/nios2/include/uapi/asm/unistd.h | 1 +
> > arch/openrisc/include/uapi/asm/unistd.h | 1 +
> > arch/score/include/uapi/asm/unistd.h | 1 +
> > arch/tile/include/uapi/asm/unistd.h | 1 +
> > arch/unicore32/include/uapi/asm/unistd.h | 1 +
> > include/uapi/asm-generic/unistd.h | 5 +++++
>
> Don't forget to add __IGNORE_getrlimit and __IGNORE_setrlimit to
> scripts/checksyscalls.sh, or you'll get warnings about missing syscalls.
>
> Cheers
> James

Hi James,

Thanks for the hint.

Yury