Re: [PATCH 09/16] platform/x86: wmi: Instantiate all devices before adding them

From: Andy Lutomirski
Date: Tue Jun 06 2017 - 12:04:13 EST


On Mon, Jun 5, 2017 at 8:03 PM, Darren Hart <dvhart@xxxxxxxxxxxxx> wrote:
> On Thu, Jun 01, 2017 at 10:43:39PM +0200, MichaÅ KÄpieÅ wrote:
>> I know I have probably started sounding like a broken record by now, but
>> I still have not seen any response (apart from the typos getting fixed)
>> to my comments on this patch which I posted in January 2016 [1].
>>
>> None of the issues I found back then are really critical, but I did
>> point out a potential memory leak (granted, an unlikely one), so it
>> might be a good idea to at least take a second look before merging.
>>
>> [1] https://www.spinics.net/lists/platform-driver-x86/msg08201.html
>
> Thanks for being persistent, some good points in there. I'd like to just squash
> these into this patch (9/16), but I'll include them here for an ack from you and
> Andy L. that this is what you meant, and consistent with his
> intent/understanding:
>

Looks good to me.