RE: [PATCH 0/4] RAS: Merge mce_amd_inj into mce-inject

From: Ghannam, Yazen
Date: Tue Jun 06 2017 - 09:36:56 EST


> -----Original Message-----
> From: Borislav Petkov [mailto:bp@xxxxxxxxx]
> Sent: Tuesday, June 06, 2017 5:33 AM
> To: Tony Luck <tony.luck@xxxxxxxxx>; Ghannam, Yazen
> <Yazen.Ghannam@xxxxxxx>
> Cc: linux-edac <linux-edac@xxxxxxxxxxxxxxx>; LKML <linux-
> kernel@xxxxxxxxxxxxxxx>
> Subject: [PATCH 0/4] RAS: Merge mce_amd_inj into mce-inject
>
> From: Borislav Petkov <bp@xxxxxxx>
>
> Hi,
>
> so there's no need to have two different injectors. Also, the mce_amd_inj
> interface is much more user-friendly because you can simply write full u64
> registers directly.
>
> So merge that functionality into mce-inject. The old /dev/mcelog functionality
> is still there, behind X86_MCELOG_LEGACY.
>
> Also, the second patch removes register_mce_write_callback() and adds an
> MCE injector notifier which allows us to have mce-inject be a module and thus
> be able to modprobe it and remove it on a production system in case we want
> to do some injecting there.
>
> Later, we might reuse that injector notifier for other stuff if it is deemed
> interesting.
>

Built module and tested the mce_amd_inj interface with no problems.

Acked-by: Yazen Ghannam <yazen.ghannam@xxxxxxx>

Thanks,
Yazen