Re: [PATCH 4.4 07/53] s390/qeth: add missing hash table initializations

[Julian Wiedmann]

On 06/05/2017 06:17 PM, Greg Kroah-Hartman wrote:
> 4.4-stable review patch.  If anyone has any objections, please let me know.
> 
Hi Greg,

please drop this patch from the 4.4-stable queue, the commit that it fixes
didn't exist in 4.4.

git describe --contains 5f78e29ceebf
v4.8-rc1~140^2~312^2~5


That also resolves the kbuild bot report for this patch.

> ------------------
> 
> From: Ursula Braun <ubraun@xxxxxxxxxxxxxxxxxx>
> 
> 
> [ Upstream commit ebccc7397e4a49ff64c8f44a54895de9d32fe742 ]
> 
> commit 5f78e29ceebf ("qeth: optimize IP handling in rx_mode callback")
> added new hash tables, but missed to initialize them.
> 
> Fixes: 5f78e29ceebf ("qeth: optimize IP handling in rx_mode callback")
> Signed-off-by: Ursula Braun <ubraun@xxxxxxxxxxxxxxxxxx>
> Reviewed-by: Julian Wiedmann <jwi@xxxxxxxxxxxxxxxxxx>
> Signed-off-by: Julian Wiedmann <jwi@xxxxxxxxxxxxxxxxxx>
> Signed-off-by: David S. Miller <davem@xxxxxxxxxxxxx>
> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> ---
>  drivers/s390/net/qeth_l3_main.c |    2 ++
>  1 file changed, 2 insertions(+)
> 
> --- a/drivers/s390/net/qeth_l3_main.c
> +++ b/drivers/s390/net/qeth_l3_main.c
> @@ -3232,6 +3232,8 @@ static int qeth_l3_probe_device(struct c
>  	rc = qeth_l3_create_device_attributes(&gdev->dev);
>  	if (rc)
>  		return rc;
> +	hash_init(card->ip_htable);
> +	hash_init(card->ip_mc_htable);
>  	card->options.layer2 = 0;
>  	card->info.hwtrap = 0;
>  	return 0;
> 
>