Re: [PATCH 0/9] mfd: Remove redundant i2c_device_id

From: Keerthy
Date: Tue Jun 06 2017 - 03:30:59 EST




On Tuesday 06 June 2017 12:47 PM, Lee Jones wrote:
> On Mon, 05 Jun 2017, Keerthy wrote:
>
>>
>>
>> On Monday 05 June 2017 04:07 PM, Lee Jones wrote:
>>> On Sun, 04 Jun 2017, Keerthy wrote:
>>>
>>>> With the introduction of probe_new function the i2c_device_id
>>>> is no longer needed. Hence the remove the same and use probe_new
>>>> instead of probe.
>>>>
>>>> Keerthy (9):
>>>> mfd: tps65217: Remove redundant i2c_device_id
>>>> mfd: tps65218: Remove redundant i2c_device_id
>>>> mfd: palmas: Remove redundant i2c_device_id
>>>> mfd: lp873x: Remove redundant i2c_device_id
>>>> mfd: lp8788: Remove redundant i2c_device_id
>>>> mfd: lp3943: Remove redundant i2c_device_id
>>>> mfd: tps65086: Remove redundant i2c_device_id
>>>> mfd: tps65090: Remove redundant i2c_device_id
>>>> mfd: tps6586x: Remove redundant i2c_device_id
>>>>
>>>> drivers/mfd/lp3943.c | 11 ++---------
>>>> drivers/mfd/lp873x.c | 12 ++----------
>>>> drivers/mfd/lp8788.c | 11 ++---------
>>>> drivers/mfd/palmas.c | 15 ++-------------
>>>> drivers/mfd/tps65086.c | 12 ++----------
>>>> drivers/mfd/tps65090.c | 12 ++----------
>>>> drivers/mfd/tps65217.c | 14 +++-----------
>>>> drivers/mfd/tps65218.c | 9 +++++----
>>>> drivers/mfd/tps6586x.c | 12 ++----------
>>>
>>> Are all of these drivers DT only?
>>
>> At least i did not find any platform code calling on to these drivers.
>> No dependency on OF as such. Hence sent these 9.
>
> I can't accept these changes on any drivers which does not depend on
> OF as a hard requirement.

Okay. So that is a per-requisite. At least palmas, tps65218, lp873x,
tps65217 imho can have the OF dependency. I will post patches for that
and then will resurrect this series.

Thanks for your feedback.


>