Re: [PATCH v2 2/5] ACPI / APEI: Switch to use new generic UUID API

From: Andy Shevchenko
Date: Mon Jun 05 2017 - 13:28:33 EST


On Mon, 2017-06-05 at 18:01 +0200, Christoph Hellwig wrote:
> > - if (!uuid_le_cmp(*(uuid_le *)gdata->section_type,
> > - ÂCPER_SEC_PLATFORM_MEM)) {
> > + if (!guid_equal(sec_type, &CPER_SEC_PLATFORM_MEM))
> > {
>
> The "!" here seems incorrect.
>
> > Â#ifdef CONFIG_ACPI_APEI_PCIEAER
> > - else if (!uuid_le_cmp(*(uuid_le *)gdata-
> > >section_type,
> > - ÂÂÂÂÂÂCPER_SEC_PCIE)) {
> > + else if (!guid_equal(sec_type, &CPER_SEC_PCIE)) {
>
> Same here.

Thanks!
Are you going to fixup when applying or better me to send an updated
version?

--
Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Intel Finland Oy