Re: [PATCH] spi: davinci: Fix compilation warning.

[Arvind Yadav]

Hi,
 yes, You are right. we are getting this warning.
drivers/spi/spi-davinci.c: In function âdavinci_spi_probeâ:
drivers/spi/spi-davinci.c:919:7: warning: assignment makes integer from 
pointer without a cast [enabled by default]
   ret = spi_davinci_get_pdata(pdev, dspi);

We should return 'int' in both the case.

 Thanks
 ~arvind

On Monday 05 June 2017 06:37 PM, Geert Uytterhoeven wrote:
> Hi Arvind,
>
> On Mon, Jun 5, 2017 at 2:14 PM, Arvind Yadav <arvind.yadav.cs@xxxxxxxxx> wrote:
> > If CONFIG_OF is disable, it'll through compilation warning.
> >
> > drivers/spi/spi-davinci.c: In function âspi_davinci_get_pdataâ:
> > drivers/spi/spi-davinci.c:880:2: warning: return makes pointer from integer without a cast [enabled by default]
> >    return -ENODEV;
> >
> > Signed-off-by: Arvind Yadav <arvind.yadav.cs@xxxxxxxxx>
> > ---
> >   drivers/spi/spi-davinci.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/spi/spi-davinci.c b/drivers/spi/spi-davinci.c
> > index 2b0805d..93a4009 100644
> > --- a/drivers/spi/spi-davinci.c
> > +++ b/drivers/spi/spi-davinci.c
> > @@ -877,7 +877,7 @@ static int spi_davinci_get_pdata(struct platform_device *pdev,
> >          *spi_davinci_get_pdata(struct platform_device *pdev,
> >                  struct davinci_spi *dspi)
> >   {
> > -       return -ENODEV;
> > +       return ERR_PTR(-ENODEV);
> >   }
> >   #endif
> And you don't get a warning for spi_davinci_probe() doing
>
>      int ret;
>
>      ret = spi_davinci_get_pdata(pdev, dspi);
>
> ?
>
> spi_davinci_get_pdata() returns int if CONFIG_OF, else a pointer.
> I guess it always should return int instead.
>
> It's been like this since the function was introduced, in commit
> aae7147dfc522062 ("spi/davinci: add OF support for the spi controller").
>
> Gr{oetje,eeting}s,
>
>                          Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                  -- Linus Torvalds