Re: [PATCH net-next] mdio: mux: make child bus walking more permissive and errors more verbose

From: David Miller
Date: Sun Jun 04 2017 - 19:31:19 EST


From: Jon Mason <jon.mason@xxxxxxxxxxxx>
Date: Wed, 31 May 2017 15:44:50 -0400

> If any errors are encountered while walking the device tree structure of
> the MDIO bus for children, the code may silently continue, silently
> exit, or throw an error and exit. This make it difficult for device
> tree writers to know there is an error. Also, it makes any error in a
> child entry of the MDIO bus be fatal for all entries. Instead, we
> should provide verbose errors describing the error and then attempt to
> continue if it all possible. Also, use of_mdio_parse_addr()
>
> Signed-off-by: Jon Mason <jon.mason@xxxxxxxxxxxx>

Looks good. Every conversion from break to continue properly gets rid
of the child_bus_node release, and this new behavior matches what was
discussed a few weeks ago.

Applied, thanks.