Re: [PATCH v5 3/8] thermal: intel_bxt_pmic_thermal: Use first level PMIC thermal irq

From: Andy Shevchenko
Date: Sat Jun 03 2017 - 09:01:01 EST


On Thu, Jun 1, 2017 at 1:37 AM,
<sathyanarayanan.kuppuswamy@xxxxxxxxxxxxxxx> wrote:
> From: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@xxxxxxxxxxxxxxx>
>
> PMIC mfd driver only exports first level irq for thermal device.
> But currently we are reading the irqs from the second level irq
> chip, So this patch fixes this issue by adding support to use
> first level PMIC thermal irq.
>

Shouldn't be this squashed to patch 2?

> Signed-off-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@xxxxxxxxxxxxxxx>
> Acked-by: Zhang Rui <rui.zhang@xxxxxxxxx>
> ---
> drivers/thermal/intel_bxt_pmic_thermal.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Changes since v1:
> * None
>
> Changes since v2:
> * Rebased on top of latest release.
>
> Changes since v3:
> * Rebased on top of latest release.
>
> diff --git a/drivers/thermal/intel_bxt_pmic_thermal.c b/drivers/thermal/intel_bxt_pmic_thermal.c
> index 0f19a39..ef6b322 100644
> --- a/drivers/thermal/intel_bxt_pmic_thermal.c
> +++ b/drivers/thermal/intel_bxt_pmic_thermal.c
> @@ -241,7 +241,7 @@ static int pmic_thermal_probe(struct platform_device *pdev)
> }
>
> regmap = pmic->regmap;
> - regmap_irq_chip = pmic->irq_chip_data_level2;
> + regmap_irq_chip = pmic->irq_chip_data;
>
> pmic_irq_count = 0;
> while ((irq = platform_get_irq(pdev, pmic_irq_count)) != -ENXIO) {
> --
> 2.7.4
>



--
With Best Regards,
Andy Shevchenko