Re: [PATCH] regmap: make LZO cache optional

From: Greg Kroah-Hartman
Date: Fri Jun 02 2017 - 20:58:55 EST


On Fri, Jun 02, 2017 at 03:15:37PM +0200, Jonas Gorski wrote:
> Commit 2cbbb579bcbe3 ("regmap: Add the LZO cache support") added support
> for LZO compression in regcache, but there were never any users added
> afterwards. Since LZO support itself has its own size, it currently is
> rather a deoptimization.
>
> So make it optional by introducing a symbol that can be selected by
> drivers wanting to make use of it.
>
> Saves e.g. ~46 kB on MIPS (size of LZO support + regcache LZO code).
>
> Signed-off-by: Jonas Gorski <jonas.gorski@xxxxxxxxx>
> ---
> I tried using google to find any users (even out-of-tree ones), but at
> best I found a single driver submission that was switched to RBTREE in
> subsequent resubmissions (MFD_SMSC).
>
> One could maybe also just drop the code because of no users for 5 years,
> but that would be up to the maintainer(s) to decide.

Let's just drop it, if there are no users, it shouldn't be there at all.

thanks,

greg k-h