Re: [PATCH v2 2/2] i2c: xgene-slimpro: Add ACPI support by using PCC mailbox

From: Hoan Tran
Date: Fri Jun 02 2017 - 16:58:09 EST


On Fri, Jun 2, 2017 at 1:31 PM, Wolfram Sang <wsa@xxxxxxxxxxxxx> wrote:
> On Mon, Apr 24, 2017 at 11:00:26AM -0700, Hoan Tran wrote:
>> This patch adds ACPI support by using PCC mailbox communication
>> interface.
>>
>> Signed-off-by: Hoan Tran <hotran@xxxxxxx>
>
> Please make use checkpatch:
>
> WARNING: braces {} are not necessary for single statement blocks
> #149: FILE: drivers/i2c/busses/i2c-xgene-slimpro.c:242:
> + if (!acpi_disabled) {
> + mbox_chan_txdone(ctx->mbox_chan, 0);
> + }
>
> Fixed that and applied to for-next, thanks!

Thanks, Wolfram!

Regards,
Hoan

>
> BTW is there anyone inside apm.com who is willing to take over maintainership
> for this driver? This person needs to review patches thoroughly, yet it usually
> means patches will go in faster.
>
> Regards,
>
> Wolfram
>