Re: [PATCH] kernel: trace: pass export pointer as argument to ->write()

From: Felipe Balbi
Date: Fri Jun 02 2017 - 06:15:14 EST



Hi,

kbuild test robot <lkp@xxxxxxxxx> writes:
> Hi Felipe,
>
> [auto build test ERROR on tip/perf/core]
> [also build test ERROR on v4.12-rc1 next-20170518]
> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
>
> url: https://github.com/0day-ci/linux/commits/Felipe-Balbi/kernel-trace-pass-export-pointer-as-argument-to-write/20170518-135452
> config: i386-allmodconfig (attached as .config)
> compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
> reproduce:
> # save the attached .config to linux build tree
> make ARCH=i386
>
> All errors (new ones prefixed by >>):
>
> drivers/hwtracing/stm/ftrace.c: In function 'stm_ftrace_write':
>>> drivers/hwtracing/stm/ftrace.c:49:19: error: incompatible type for argument 1 of 'stm_source_write'
> stm_source_write(stm->data, STM_FTRACE_CHAN, buf, len);
> ^~~
> In file included from drivers/hwtracing/stm/ftrace.c:18:0:
> include/linux/stm.h:136:13: note: expected 'struct stm_source_data *' but argument is of type 'struct stm_source_data'
> int notrace stm_source_write(struct stm_source_data *data, unsigned int chan,
> ^~~~~~~~~~~~~~~~
>
> vim +/stm_source_write +49 drivers/hwtracing/stm/ftrace.c
>
> 43 */
> 44 static void notrace
> 45 stm_ftrace_write(struct trace_export *export, const void *buf, unsigned int len)
> 46 {
> 47 struct stm_ftrace *stm = container_of(export, struct stm_ftrace, ftrace);
> 48
> > 49 stm_source_write(stm->data, STM_FTRACE_CHAN, buf, len);

sorry, just came back from vacations and noticed this. I'll send a v2 shortly.

--
balbi

Attachment: signature.asc
Description: PGP signature