Re: [PATCH] clk: sunxi-ng: select SUNXI_CCU_MULT for sun8i-a83t

From: Arnd Bergmann
Date: Thu Jun 01 2017 - 05:07:53 EST


On Thu, Jun 1, 2017 at 9:17 AM, Stephen Boyd <sboyd@xxxxxxxxxxxxxx> wrote:
> On 05/23, Arnd Bergmann wrote:
>> On Tue, May 23, 2017 at 9:19 AM, Chen-Yu Tsai <wens@xxxxxxxx> wrote:
>> An alternative would be to remove all the dependencies as 'lib-y'
>> in the Makefile and remove the individual Kconfig symbols. That
>> way, we would always build all of them when CONFIG_SUNXI_CCU
>> is enabled, but the linker would drop the ones that do not get
>> referenced.
>
> In this case you're right, and we should change them to lib-y in
> the Makefile and then let the linker figure this all out. No more
> dependency patches. I think we only need to do this sort of
> Kconfig stuff when we want to make a library .ko file that each
> SoC specific driver depends on for common code.
>
> It would be cool if the build system could figure that all out
> for us, and let us have something like modlib-y that makes it a
> library (archive) if all objects depending on it are builtin and
> we have CONFIG_MODULES=n, or makes it into an object file if
> something is builtin that depends on it, or makes it into a
> module if everything that depends on it is a module.

In this case, there are no loadable modules, the sunxi clk drivers
can only be built-in, which should simplify the problem a lot.

Arnd