Re: [PATCH 3/7] clk: mvebu: cp110: do not depend anymore of the *-clock-output-names

From: Rob Herring
Date: Tue May 23 2017 - 11:19:17 EST


On Fri, May 19, 2017 at 05:55:21PM +0200, Gregory CLEMENT wrote:
> Using the *-clock-output-names property was a convenient way to have a
> unique name for each clock even when there are multiple cp110 blocks
> as we can find on Armada 8K.
>
> However it has some drawbacks: the main one being a stronger link than
> necessary between the driver and the device tree. For example the clock
> name can't be changed, removed or moved. It is still the early stage of
> introduction of the Armada 7K/8K and the hardware is still not totally
> documented, especially for the clock part. By removing the use of
> *-clock-output-names it will be easier to add new clocks without breaking
> the compatibility.
>
> The name of each clock is now created by using its physical address as a
> prefix (as it was done for the platform device names). Thanks to this we
> have an automatic way to compute a unique name.
>
> Signed-off-by: Gregory CLEMENT <gregory.clement@xxxxxxxxxxxxxxxxxx>
> ---
> Documentation/devicetree/bindings/arm/marvell/cp110-system-controller0.txt | 14 +----------
> drivers/clk/mvebu/cp110-system-controller.c | 106 ++++++++++++++++++++++++++++++++++++++++++++----------------------------
> 2 files changed, 65 insertions(+), 55 deletions(-)

Acked-by: Rob Herring <robh@xxxxxxxxxx>