Re: [PATCH] Bluetooth: hci_ll: Fix download_firmware() return when __hci_cmd_sync fails

From: Rob Herring
Date: Tue May 23 2017 - 09:45:34 EST


On Mon, May 22, 2017 at 8:50 AM, Guodong Xu <guodong.xu@xxxxxxxxxx> wrote:
> When __hci_cmd_sync() fails, download_firmware() should also fail, and
> the same error value should be returned as PTR_ERR(skb).
>
> Without this fix, download_firmware() will return a success when it actually
> failed in __hci_cmd_sync().
>
> Fixes: 371805522f87 ("bluetooth: hci_uart: add LL protocol serdev driver support")
> Signed-off-by: Guodong Xu <guodong.xu@xxxxxxxxxx>
> ---
> drivers/bluetooth/hci_ll.c | 1 +
> 1 file changed, 1 insertion(+)

Acked-by: Rob Herring <robh@xxxxxxxxxx>