Re: [PATCH] scsi: hisi_sas: add null check before indirect pointer dereference

From: John Garry
Date: Tue May 23 2017 - 03:45:12 EST


On 22/05/2017 19:00, Gustavo A. R. Silva wrote:
Add null check before indirectly dereferencing pointer task->lldd_task
in statement u32 tag = slot->idx;


I don't think that this is a valid scenario, but protecting against a possible NULL dereference is prudent. Thanks

Addresses-Coverity-ID: 1373843
Signed-off-by: Gustavo A. R. Silva <garsilva@xxxxxxxxxxxxxx>

Reviewed-by: John Garry <john.garry@xxxxxxxxxx>