Re: [PATCH] mm: Define KB, MB, GB, TB in core VM

From: Andrew Morton
Date: Mon May 22 2017 - 17:11:54 EST


On Mon, 22 May 2017 16:47:42 +0530 Anshuman Khandual <khandual@xxxxxxxxxxxxxxxxxx> wrote:

> There are many places where we define size either left shifting integers
> or multiplying 1024s without any generic definition to fall back on. But
> there are couples of (powerpc and lz4) attempts to define these standard
> memory sizes. Lets move these definitions to core VM to make sure that
> all new usage come from these definitions eventually standardizing it
> across all places.

Grep further - there are many more definitions and some may now
generate warnings.

Newly including mm.h for these things seems a bit heavyweight. I can't
immediately think of a more appropriate place. Maybe printk.h or
kernel.h.