Re: [PATCH v1] dmaengine: DW DMAC: Handle return value of clk_prepare_enable

From: Viresh Kumar
Date: Mon May 22 2017 - 06:40:51 EST


Create the patch using this command and the unnecessary "v1" in the
subject will go away:

$ git format-patch -C -M --thread=shallow

On 22-05-17, 16:01, Arvind Yadav wrote:
> clk_prepare_enable() can fail here and we must check its return value.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@xxxxxxxxx>
> ---
> drivers/dma/dw/platform.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/dma/dw/platform.c b/drivers/dma/dw/platform.c
> index c639c60..bc31fe8 100644
> --- a/drivers/dma/dw/platform.c
> +++ b/drivers/dma/dw/platform.c
> @@ -306,8 +306,12 @@ static int dw_resume_early(struct device *dev)
> {
> struct platform_device *pdev = to_platform_device(dev);
> struct dw_dma_chip *chip = platform_get_drvdata(pdev);
> + int ret;
> +
> + ret = clk_prepare_enable(chip->clk);
> + if (ret)
> + return ret;
>
> - clk_prepare_enable(chip->clk);
> return dw_dma_enable(chip);
> }

You don't need to resend it for now.

Acked-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>

--
viresh