gpio-exar: Why filtering out Commtech devices?

From: Jan Kiszka
Date: Sun May 21 2017 - 07:46:14 EST


Hi Sudip,

why do we carry

if (pcidev->vendor != PCI_VENDOR_ID_EXAR)
return -ENODEV;

in gpio_exar_probe? This effectively prevents that

EXAR_DEVICE(COMMTECH, COMMTECH_4222PCIE, pbn_exar_XR17V35x),
EXAR_DEVICE(COMMTECH, COMMTECH_4224PCIE, pbn_exar_XR17V35x),
EXAR_DEVICE(COMMTECH, COMMTECH_4228PCIE, pbn_exar_XR17V35x),

gain GPIO support. Do those devices lack access to the pins? Or can we
drop the filter. I don't have access to those devices, just wondering
because the code is not explaining the reason.

Jan

--
Siemens AG, Corporate Technology, CT RDA ITP SES-DE
Corporate Competence Center Embedded Linux