Re: [PATCH BUGFIX] block, bfq: access and cache blkg data only when safe

From: Jens Axboe
Date: Fri May 19 2017 - 10:37:16 EST


On 05/19/2017 02:39 AM, Paolo Valente wrote:
> @@ -692,8 +725,7 @@ void bfq_pd_offline(struct blkg_policy_data *pd)
> /*
> * The idle tree may still contain bfq_queues belonging
> * to exited task because they never migrated to a different
> - * cgroup from the one being destroyed now. No one else
> - * can access them so it's safe to act without any lock.
> ++ * cgroup from the one being destroyed now.
> */
> bfq_flush_idle_tree(st);
>

Looks like an extra '+' snuck into that hunk.

--
Jens Axboe