Re: [PATCH] net1080: Mark nc_dump_ttl() as __maybe_unused

From: Matthias Kaehlcke
Date: Thu May 18 2017 - 12:44:42 EST


Hi David,

El Thu, May 18, 2017 at 10:48:08AM -0400 David Miller ha dit:

> From: Matthias Kaehlcke <mka@xxxxxxxxxxxx>
> Date: Wed, 17 May 2017 15:17:08 -0700
>
> > The function is not used, but it looks useful for debugging. Adding the
> > attribute fixes the following clang warning:
> >
> > drivers/net/usb/net1080.c:271:20: error: unused function
> > 'nc_dump_ttl' [-Werror,-Wunused-function]
> >
> > Signed-off-by: Matthias Kaehlcke <mka@xxxxxxxxxxxx>
>
> For this and the r8152 patch, I definitely prefer that the function is
> removed.
>
> If someone needs them, they can pull it out of the GIT history.

Thanks for you comments, I'll send out updated patches soon.