Re: [PATCH v3 1/2] lib/btree.c: optimise the code by previously getpos function

From: Andy Shevchenko
Date: Thu May 18 2017 - 05:50:47 EST


On Thu, May 18, 2017 at 11:35 AM, Leno Hou <lenohou@xxxxxxxxx> wrote:
> Rework the getpos() helper function and use it to remove various
> open-coded implemetnations of its funtionality.
>
> v2 -> v3:
> - getfill() returns no entry if not found the fill position
>
> v1 -> v2:
> - getpos() returns no entry if not found the key

As far as I read Andrew's message he is not against new semantics of
getpos(), which I still consider is good to have, but rather not to
forget update users accordingly.

Would it be worth doing like that?

--
With Best Regards,
Andy Shevchenko