Re: [PATCH v5 1/3] perf: export perf_event_update_userpage()

From: Mark Rutland
Date: Wed May 17 2017 - 06:46:27 EST


Hi Jan,

On Wed, May 17, 2017 at 10:31:20AM +0200, Jan Glauber wrote:
> Export perf_event_update_userpage() to make it usable from a module.
>
> Signed-off-by: Jan Glauber <jglauber@xxxxxxxxxx>

Please make sure to Cc the relevant maintainers, e.g. those listed by:

get_maintainer.pl -f kernel/events/core.c

... I've added them this time.

It would be nice for the commit message to state that this is the only
thing blocking building some system PMU drivers as modules.

Otherwise, this looks sane to me.

Thanks,
Mark.

> ---
> kernel/events/core.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/kernel/events/core.c b/kernel/events/core.c
> index 6e75a5c..6578b9f 100644
> --- a/kernel/events/core.c
> +++ b/kernel/events/core.c
> @@ -4933,6 +4933,7 @@ void perf_event_update_userpage(struct perf_event *event)
> unlock:
> rcu_read_unlock();
> }
> +EXPORT_SYMBOL_GPL(perf_event_update_userpage);
>
> static int perf_mmap_fault(struct vm_fault *vmf)
> {
> --
> 2.9.0.rc0.21.g7777322
>