Re: [PATCH] nvmem: core: Prevent memory leak when device is unregistered

From: Mika Westerberg
Date: Wed May 17 2017 - 05:10:46 EST


On Tue, May 16, 2017 at 02:33:55PM -0700, Andrey Smirnov wrote:
> On Mon, May 15, 2017 at 4:13 AM, Mika Westerberg
> <mika.westerberg@xxxxxxxxxxxxxxx> wrote:
> > The nvmem_unregister() calls device_del() for the device but forgets to
> > call put_device() to actually release the device object which causes
> > that memory to be leaked.
> >
> > Fix this by calling device_unregister() for the device intead which also
> > calls put_device() for the device releasing it eventually.
> >
> > Signed-off-by: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>
> > ---
>
> FWIW, I submitted similar fix for this here:
>
> lkml.kernel.org/r/20170418142454.23921-2-andrew.smirnov@xxxxxxxxx

Cool, let's go with that one instead then :)