Re: [PATCH 1/2] arm64: marvell: dts: fill MachiatoBin board description

From: Russell King - ARM Linux
Date: Tue May 16 2017 - 06:03:08 EST


On Tue, May 16, 2017 at 11:55:35AM +0200, Thomas Petazzoni wrote:
> Hello,
>
> On Tue, 16 May 2017 10:50:27 +0100, Russell King - ARM Linux wrote:
>
> > I can't see how you can say that when the branch contains support for
> > SDHCI and ethernet. It obviously will collide, since it conflicts with
> > the changes I have.
>
> Correct, but Marcin has submitted patches, and you haven't.

As I said, give me a friggin chance. You know full well that I've been
working on this, working with you and submitting patches.

> > > The board is starting to get really popular and a lot has been happening
> > > around it recently - missing bits like 'chosen' node or the interfaces
> > > is pretty annoying.
> >
> > Given that features like SDHCI and basic ethernet support have only just
> > been merged during the merge window, how about giving those who are
> > supporting the platform some time to organise their trees and get patches
> > out there, rather than cutting across those who have put considerable
> > effort into the platform already, or working with those who have.
>
> I believe if you say that, it's because you don't know how much work
> Marcin is doing behind the scenes on supporting Marvell platforms, and
> not only at the Linux kernel level.

Maybe Marcin doesn't know how much work I'm doing supporting this board?

> > The whole Armada 8k support is all very new, and there's still lots of
> > fundamental bits that are missing - pinmux and gpio are the two biggest
> > ones.
> >
> > I've already put effort into cleaning up the mvebu pinmux code (already
> > merged) so that we can cleanly merge the pinmux support, but both of
> > these are a sticking point with free-electrons - they have a view on
> > how it should be represented in DT which does not fit with the current
> > orion-gpio usage, nor with the "system controller" being in drivers/clk.
>
> Grégory Clement has been working on this, and he has a patch series
> almost ready to submission.

You've seen my patches, because I've sent them to you in the past.

> > The code which I have in my tree is correct for the Armada 8k hardware
> > (which has some weirdness about which gpios on each CP110 appear to the
> > external world - some are used for inter-CP110 communication and must
> > not be exposed) so any additional work should be based on the code in
> > my tree.
>
> No, there is no rule like this in the kernel community. Whatever is in
> your private tree does not matter. Until it gets submitted, it doesn't
> exist, and nobody is forced to base its work on top of your
> unknown/private trees.

It _has_ been submitted - a few months ago - so you're talking rubbish
here. You just need to check your mailbox.

--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.