Re: [net-ipv4] question about arguments position

From: Gustavo A. R. Silva
Date: Thu May 04 2017 - 15:25:00 EST



Quoting Joe Perches <joe@xxxxxxxxxxx>:

[]
> > +/*
> > + * Ignore the position of the arguments req->id.idiag_dport and
> > + * req->id.idiag_sport in both calls to inet_lookup() and inet6_lookup()
> > + * functions, once this is a locked in behavior exposed to user space.
> > + * Changing this will break things for people.
> > + */
> > struct sock *inet_diag_find_one_icsk(struct net *net,
> > struct inet_hashinfo *hashinfo,
> > const struct inet_diag_req_v2 *req)
> >
>
> Seems sensible. Thanks.

Should I resend it in a full and proper format or it can taken from here?

If you want it applied, it should be resent as a full patch
with your sign-off.

I'll send it shortly.

Thanks for clarifying
--
Gustavo A. R. Silva