Re: [PATCH] bitops.h: use BITS_PER_LONG to simplify BITS_TO_LONGS

From: Wei Yang
Date: Tue May 02 2017 - 09:28:31 EST


Hi, masters

Not sure this one is acceptable?

On Sat, Mar 18, 2017 at 08:37:43AM +0800, Wei Yang wrote:
>The second parameter is the number of bits for type "long", which is
>already defined in header file.
>
>This patch replace the calculation with macro to make it more readable.
>
>Signed-off-by: Wei Yang <richard.weiyang@xxxxxxxxx>
>---
> include/linux/bitops.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/include/linux/bitops.h b/include/linux/bitops.h
>index a83c822c35c2..923fe72d31e3 100644
>--- a/include/linux/bitops.h
>+++ b/include/linux/bitops.h
>@@ -10,7 +10,7 @@
> #define BIT_ULL_MASK(nr) (1ULL << ((nr) % BITS_PER_LONG_LONG))
> #define BIT_ULL_WORD(nr) ((nr) / BITS_PER_LONG_LONG)
> #define BITS_PER_BYTE 8
>-#define BITS_TO_LONGS(nr) DIV_ROUND_UP(nr, BITS_PER_BYTE * sizeof(long))
>+#define BITS_TO_LONGS(nr) DIV_ROUND_UP(nr, BITS_PER_LONG)
> #endif
>
> /*
>--
>2.11.0

--
Wei Yang
Help you, Help me

Attachment: signature.asc
Description: PGP signature