Re: s3c24xx: Use devm_kcalloc() in s3c24xx_dma_probe()

From: SF Markus Elfring
Date: Sun Apr 23 2017 - 07:11:43 EST


>> WARNING: Prefer devm_kcalloc over devm_kzalloc with multiply
> For example. Also I just noticed some previous comment by Krzysztof that
> pointed that out already.
>
> My suggestion: One sentence describing that the current situation is.

Why do you find the sentence for the multiplication information inappropriate
(or incomplete) at the moment?


> Another sentence explaining why this is bad/undesirable.

Which details do you miss here?


> In this case, the output of the checkpatch script would come in handy.

Its implementation of the check âALLOC_WITH_MULTIPLYâ considers only an other
search pattern so far.

* Do you find it worthwhile to add a prefix like âdevm_â to the used
regular expression?

* Would like to improve any related scripts for the semantic patch language
(Coccinelle software) a bit more?


> With this, you avoid cramming every information into one long and
> complicated sentence.

Thanks for your feedback about other wording preferences.

Regards,
Markus