Re: [PATCH] rtc: sh: mark PM functions as unused

From: Alexandre Belloni
Date: Sat Apr 22 2017 - 12:02:25 EST


On 19/04/2017 at 19:52:43 +0200, Arnd Bergmann wrote:
> The sh_rtc_set_irq_wake() function is only called from the suspend/resume handlers
> that may be hidden, causing a harmless warning:
>
> drivers/rtc/rtc-sh.c:724:13: error: 'sh_rtc_set_irq_wake' defined but not used [-Werror=unused-function]
> static void sh_rtc_set_irq_wake(struct device *dev, int enabled)
>
> The most reliable way to avoid the warning is to remove the existing #ifdef
> and mark the two functions as __maybe_unused so the compiler can silently
> drop all three when there is no reference.
>
> Fixes: dab5aec64bf5 ("rtc: sh: add support for rza series")
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> ---
> drivers/rtc/rtc-sh.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
Applied, thanks.

--
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com